Use write_str instead of write_fmt when no formatting is needed #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Write_fmt (what write! expands to) needs to be set up with an std::fmt::Arguments object that is consequently iterated. All segments of the format string get Display::fmt called on them and those implementations usually result in calling some form of write_str (at least for &str). This is a minor change that only saves few unnecessary cyles and is mostly done for cosmetic reasons. It finishes the work started in 3eaed54.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
write_fmt(whatwrite!expands to) needs to be set up with anstd::fmt::Argumentsobject that is consequently iterated. All segments of the format string getDisplay::fmtcalled on them and those implementations usually result in calling some form ofwrite_str(at least for&str).This is a minor change that only saves few unnecessary cyles and is mostly done for cosmetic reasons. It finishes the work started in 3eaed54.
This follows a discussion in gtk-rs/gtk3-rs#155. The change results in hundreds of file changes in gtk-rs which is a lot of noise to bear. The new format of
f.write_str("Some string literal")is nicer to read though, and we're already making massive changes with the docs anyhow.