basic_subclass: fix name of our GObject subclasss type

[alatiera]

Close #307

[alatiera]

cc @sdroege I think this is correct but not entirely sure. The name constant there corresponds to what we would set with ClassName in C right?

[sdroege]

The name constant there corresponds to what we would set with ClassName in C right?

Yes. That's why I usually do things different than you did here. An imp module with struct Foo for the implementation, and outside the imp module a struct Foo for the public type. This way you don't have the confusion about type names and can distinguish between the two via imp::Foo and super::Foo.

[sdroege]

Looks good but can you also replace that useless priv_ here with self? https://github.com/gtk-rs/examples/blob/master/src/bin/basic_subclass.rs#L170 https://github.com/gtk-rs/examples/blob/master/src/bin/basic_subclass.rs#L190

[alatiera]

done as well, I think its from when I initially had implemented the functions on the public struct.

[sdroege]

Looks good to me, @GuillaumeGomez please merge when green :)

[GuillaumeGomez]

👍

[sdroege]

@GuillaumeGomez green

[GuillaumeGomez]

Thanks @alatiera !