Propagate individual sections with titles and prerequisites as needed #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This PR updates the endpoint for fetching the list of all available terms
Changed the finals mapping to adhere to the new sections' time format --------- Co-authored-by: Hailey Ho <[email protected]>
Resolves #13 ### Summary This PR edits the parsing logic so that a section has a final if it satisfies ALL of the following conditions: 1. Has a "Lecture" designation for its schedule type 2. Has at least 2 credit hours 3. Not a VIP course In addition, this PR also updates how credit hours are parsed from Oscar. Apparently, Oscar's data entry is not very consistent. The current field that the crawler uses to obtain credit hours is unreliable and can be null/undefined. As a result, we would need to combine scraping data from another field to eliminate all null credit hours as much as possible. If null credit hours still exist after this, it will default to 0. --------- Co-authored-by: Hailey Ho <[email protected]>
* Added request to /classSearch/getTerms to generate the session * Decorate banner requests with user-agent header --------- Co-authored-by: Hailey Ho <[email protected]>
* fix ssl issue * workflow dispatch * nit * nit * nit
* fix ssl issue * workflow dispatch * nit * nit * nit * fix action
* fix ssl issue * workflow dispatch * nit * nit * nit * fix action * fixed ssl local error * fixed linux support * fixed linux spaces --------- Co-authored-by: Yatharth Bhargava <[email protected]> Co-authored-by: Yatharth Bhargava <[email protected]>
|
This is meant for the crawler-v2 repo. I have no clue why 'compare and create pull request' moved me to the v1 repo... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #267 from gt-scheduler/website#267