Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix // in URL which breaks Cloudflare API since April 2020 #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fgagne
Copy link

@fgagne fgagne commented May 22, 2020

The previous form ${storage_dir%%+(/)} and ${cf_api_url%%+(/)} ain't working on my prod env, It probably needs the extglob option which ain't enabled by default. This cause // in url which cause problem with Couldflare API since about mid April 2020.

Solution: just remove the last trailing slash.

The previous form ${storage_dir%%+(/)} and ${cf_api_url%%+(/)} ain't working on my prod env, It probably needs the extglob option which ain't enable by default. This cause // in url which cause problem with Couldflare API since about mid April 2020.

Solution: just remove the last trailing slash.
@jdkelleher
Copy link

I hadn't realized there was a Cloudflare issue until I saw this pull request and tested.

Before patch

{
  "result": null,
  "success": false,
  "errors": [
    {
      "code": 7000,
      "message": "No route for that URI"
    }
  ],
  "messages": []
}

After patch

Record updated.

Looks good to me and thank you for the reminder to not throw away return codes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants