Extract hard-coded strings into resources

Signed-off-by: gstraube <[email protected]>
gstraube · Jan 8, 2018 · 7e25e4b · 7e25e4b
1 parent 52081c9
commit 7e25e4b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/app/src/main/java/com/github/cythara/MainActivity.java b/app/src/main/java/com/github/cythara/MainActivity.java
@@ -90,7 +90,7 @@ public boolean onOptionsItemSelected(MenuItem item) {
                 int checkedItem = useStandardNotation ? 0 : 1;
 
                 AlertDialog.Builder builder = new AlertDialog.Builder(this);
-                builder.setTitle("Choose notation");
+                builder.setTitle(R.string.choose_notation);
                 builder.setSingleChoiceItems(R.array.notations, checkedItem,
                         new DialogInterface.OnClickListener() {
                             @Override
@@ -134,7 +134,7 @@ public void onRequestPermissionsResult(int requestCode, @NonNull String permissi
                     startRecording();
                 } else {
                     AlertDialog alertDialog = new AlertDialog.Builder(MainActivity.this).create();
-                    alertDialog.setTitle("Permission required");
+                    alertDialog.setTitle(R.string.permission_required);
                     alertDialog.setMessage("Microphone permission is required. App will be closed");
                     alertDialog.setButton(AlertDialog.BUTTON_NEUTRAL, "OK",
                             new DialogInterface.OnClickListener() {

diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
@@ -2,6 +2,8 @@
     <string name="app_name">Cythara</string>
     <string name="privacy_policy">Show privacy policy</string>
     <string name="set_notation">Set notation</string>
+    <string name="choose_notation">Choose notation</string>
+    <string name="permission_required">Permission required</string>
     <string-array name="tunings">
         <item>Guitar (standard)</item>
         <item>Guitar (Drop D)</item>