-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow custom formatting #37
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Argument parsing done
Also fixed bug in parser which lead to non interpolated things being interpolated
…n values the parser is getting a drop messy
custom formatting interpolation now follows (mostly) the same rules as `fomat!` custom formatting interpolation now report (mostly) the same errors as `format!` fixed some copy pasted error reporting
gsingh93
approved these changes
Jul 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have time to do a thorough review, but looks good after a quick skim and the tests pass, so approved. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets you use
So for example, when you call
foo
with1
it will print:Entering foo(a is 1 ...)
.Currently, it is combined with
prefix_enter
orprefix_exit
when printing.You can also do custom formatting for when a function exits with
format_exit
.For example,
#[trace(format_enter="returning {r} ...")
,r
is used to denotewhen to interpolate the return value, but it is easy to change to a different symbol.
This technically fixes #30, because you can do
#[trace(format_exit="")
,and not interpolate anything.
Generally, the formatting follows the same rules and produces the same errors as
format!
,but it does not (yet) allow for anything past basic interpolation, like pretty printing or padding.
Note:
format_enter
and orformat_exit
cannot be used withpretty
.