Merge pull request #67 from ankurp/fix/chrome-lighthouse

Adding fix for Chrome Lighthouse not being detected as a bot
gshutler · Dec 4, 2024 · d61055e · d61055e
2 parents 3ed4d04 + 22d2271
commit d61055e
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/lib/user_agent/browsers/base.rb b/lib/user_agent/browsers/base.rb
@@ -78,6 +78,10 @@ def bot?
         # list will be rejected.
         elsif detect_comment_match(/bot/i)
           true
+        # Google PageSpeed Insights adds "Chrome-Lighthouse" to the user agent
+        # https://stackoverflow.com/questions/16403295/what-is-the-name-of-the-google-pagespeed-user-agent
+        elsif detect_product("Chrome-Lighthouse")
+          true
         elsif product = application.product
           product.include?('bot')
         else

diff --git a/spec/browsers/chrome_lighthouse_user_agent_spec.rb b/spec/browsers/chrome_lighthouse_user_agent_spec.rb
@@ -0,0 +1,9 @@
+require 'user_agent'
+
+describe "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/94.0.4590.2 Safari/537.36 Chrome-Lighthouse" do
+  before do
+    @useragent = UserAgent.parse("Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/94.0.4590.2 Safari/537.36 Chrome-Lighthouse")
+  end
+
+  it { expect(@useragent).to be_bot }
+end