Improvements for the action buttons, closes #2386

[wshoy]

In this PR:

• Date and time
  • Made setting dates easier by not disabling the "Pick Date/Time" buttons and changing the current date checkbox behavior, fixes Checkboxes in "Date and time" action button dialog not saved #2386
  • The format checkbox also disables the "Pick Date/Time" buttons
  • The current date checkbox updates the date preview
  • Removed the word "Always" from the current date checkbox description (retranslation needed) Checkboxes in "Date and time" action button dialog not saved #2386 (comment)_
• Due date
  • Used "Due date" instead of "Current date" for the due date action button text
• Priority
  • Added long press behavior to set/unset priority from the previous line
  • Made the highlighting colors equally bright and replaced yellow with magenta
• Bold, Italic, etc.
  • Fixed a bug where the button didn't remove characters in the first word

[harshad1]

Could you describe the behaviour you are trying to achieve here?

[wshoy]

In my experience, when adding a new task below another, the task's priority would usually be the same.
The goal is to set/unset the priority to be the same as the top one.

This is what felt right to me for multi line:

• if at least one priority is different than the top one - set all to the top priority
• if they are the same and same as the top one - remove priorities as there is nothing else to do (another press restores it)

That also means, that any priorities can be removed with at most two presses.
Might also add a check for the bottom line as well.

[harshad1]

So long pressing the priority button copies the priority from the first task to all the others?

Does this really need a long press? Currently one can select all the tasks and assign them a priority pretty easily.

You can select multiple tasks by simply creating a selection covering multiple tasks in the editor or by using the search dialog.

So search -> select all -> priority action -> select priority to assign to all selected tasks.

[wshoy]

So long pressing the priority button copies the priority from the first task to all the others?

By "top" I mean the previous line from selection. Priority is copied to the selected lines.
The exact behavior is not set in stone, it's what I came up with.

Does this really need a long press? Currently one can select all the tasks and assign them a priority pretty easily.

In my experience, it feels much easier and responsive in daily use, as it makes creating another task with priority a little bit faster than the other methods.

[harshad1]

Ah.

So the current workflow is:

select -> priority action -> choose

And the new workflow for this use case is

select -> long press priority action

We're replacing 2 short presses with one long press.

[wshoy]

Well put

[gsantner]

Why did you change those colors?

[wshoy]

The B and C colors were disproportionately bright compared to the red color of A. The A priority, being most important, should be at least as much noticeable as the other ones.
The yellow E color was much brighter than all the other colors and didn't match the hue sequence.

I used the perceived brightness formula to match the colors:

Before:
EF2929 - 0.53
F57900 - 0.64
73D216 - 0.68
0099CC - 0.53
EDD400 - 0.81
888A85 - 0.54

After:
EF2929 - 0.53
d16900 - 0.55
59a112 - 0.52
0091c2 - 0.51
a952cb - 0.51
878986 - 0.53