Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Azure): add new check for private DNS zones #1455

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

johannes-engler-mw
Copy link

Description

Adds #1454 .

This PR adds an assertion helper for Azure Private DNS Zones.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added support for Azure Private DNS Zones assertion helpers.

modules/azure/privatednszone.go Outdated Show resolved Hide resolved
modules/azure/privatednszone.go Outdated Show resolved Hide resolved
modules/azure/client_factory.go Outdated Show resolved Hide resolved
@johannes-engler-mw
Copy link
Author

@denis256 I have implemented your comments, please review.

@johannes-engler-mw
Copy link
Author

@denis256 Could you have a look?

@james03160927
Copy link
Contributor

Hi @johannes-engler-mw, I can help to trigger relevant tests for this change.
Also, it seems like you need to resolve conflicts for some of the recent commits.

@james03160927 james03160927 self-assigned this Jan 13, 2025
@johannes-engler-mw
Copy link
Author

Hi @james03160927, i have fixed the merge conflict. Please retrigger the tests.

@james03160927
Copy link
Contributor

Hi @johannes-engler-mw, can you modify the title to remove WIP since it's already being reviewed?
Also, did you confirm the test is passing with your change (the test you created in this PR?)

@johannes-engler-mw johannes-engler-mw changed the title [WIP] feat(Azure): add new check for private DNS zones feat(Azure): add new check for private DNS zones Jan 20, 2025
@johannes-engler-mw
Copy link
Author

@james03160927 I have run my new tests and they where successful.

Copy link
Contributor

@james03160927 james03160927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you update the branch with the latest change merged in main? You can just click the button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants