-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Azure): add new check for private DNS zones #1455
base: main
Are you sure you want to change the base?
feat(Azure): add new check for private DNS zones #1455
Conversation
@denis256 I have implemented your comments, please review. |
@denis256 Could you have a look? |
Hi @johannes-engler-mw, I can help to trigger relevant tests for this change. |
Hi @james03160927, i have fixed the merge conflict. Please retrigger the tests. |
Hi @johannes-engler-mw, can you modify the title to remove WIP since it's already being reviewed? |
@james03160927 I have run my new tests and they where successful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Can you update the branch with the latest change merged in main? You can just click the button.
Description
Adds #1454 .
This PR adds an assertion helper for Azure Private DNS Zones.
TODOs
Read the Gruntwork contribution guidelines.
Release Notes (draft)
Added support for Azure Private DNS Zones assertion helpers.