Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isort to workflow #8

Merged
merged 5 commits into from
Nov 17, 2023
Merged

Add isort to workflow #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6536d0b
Add isort to workflow
XuanWang-Amos Nov 17, 2023
f6adf6a
Fail on error
XuanWang-Amos Nov 17, 2023
f43e081
Fix issue found by isort
XuanWang-Amos Nov 17, 2023
87f0a05
Fix typo in isort
XuanWang-Amos Nov 17, 2023
69b1aed
Fix isort
XuanWang-Amos Nov 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/psm-interop.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,3 +85,12 @@ jobs:
with:
options: "--check --config black.toml"
version: "23.3.0"

isort-check:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: isort/isort-action@v1
with:
configuration: "--diff --check-only --dont-follow-links --settings-path=black.toml"
isort-version: "5.9.2"
4 changes: 1 addition & 3 deletions framework/rpc/grpc_testing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,14 @@
https://github.com/grpc/grpc/blob/master/src/proto/grpc/testing/test.proto
"""
import logging
import sys
from typing import Iterable, Optional, Tuple

import grpc
from grpc_health.v1 import health_pb2
from grpc_health.v1 import health_pb2_grpc

import framework.rpc
import sys

print(f">>>>path: {sys.path}")
from protos import empty_pb2
from protos import messages_pb2
from protos import test_pb2_grpc
Expand Down