Skip to content

RoundRobin Test flakiness fix #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 28, 2025
Merged

Conversation

pawbhard
Copy link
Contributor

@pawbhard pawbhard commented May 15, 2025

Added check for ensuring number of health endpoints are equal to REPLICA before proceeding. b/346482844

@pawbhard pawbhard changed the title [DRAFT] Round robin Test fix [DRAFT] RoundRobin Test flakiness fix May 16, 2025
@pawbhard pawbhard requested a review from arjan-bal May 16, 2025 04:39
@pawbhard pawbhard changed the title [DRAFT] RoundRobin Test flakiness fix RoundRobin Test flakiness fix May 16, 2025
@pawbhard pawbhard marked this pull request as ready for review May 16, 2025 05:11
@pawbhard pawbhard requested a review from a team as a code owner May 16, 2025 05:11
@sergiitk sergiitk requested a review from eshitachandwani May 21, 2025 17:52
@sergiitk
Copy link
Member

sergiitk commented May 28, 2025

Copy link
Member

@sergiitk sergiitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please add internal metabug ref b/ to the PR description.

@kannanjgithub kannanjgithub merged commit adea348 into grpc:main May 28, 2025
6 checks passed
@pawbhard
Copy link
Contributor Author

LGTM, but please add internal metabug ref b/ to the PR description.

Done

@pawbhard pawbhard deleted the round_robin_trial branch May 28, 2025 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants