Skip to content

Refactor CSM Observability Test logic into Mixin class #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stanley-cheung
Copy link
Contributor

The CSM Observability Test logic has been duplicated 3 times by now. Refactoring common logic into a Mixin class.

@stanley-cheung stanley-cheung requested a review from a team as a code owner March 21, 2025 18:27
@stanley-cheung stanley-cheung requested a review from sergiitk March 21, 2025 18:27
@stanley-cheung stanley-cheung marked this pull request as draft March 21, 2025 18:27
@sergiitk
Copy link
Member

@XuanWang-Amos, could you please give it the first look?

@sergiitk sergiitk requested a review from XuanWang-Amos March 25, 2025 23:26
Copy link
Contributor

@XuanWang-Amos XuanWang-Amos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM, please add a test run and fix sanity tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants