Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated API #2166

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Remove deprecated API #2166

merged 2 commits into from
Jan 17, 2025

Conversation

gjcairo
Copy link
Collaborator

@gjcairo gjcairo commented Jan 17, 2025

No description provided.

@gjcairo gjcairo added the ⚠️ semver/major Breaks existing public API. label Jan 17, 2025
@gjcairo gjcairo requested a review from glbrntt January 17, 2025 17:06
glbrntt
glbrntt approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Gus, looks good modulo docs failing

@gjcairo
Copy link
Collaborator Author

gjcairo commented Jan 17, 2025

API breaks are expected:

💔 API breakage: var ServerContext.peer has been removed
💔 API breakage: func GRPCClient.run() has been removed
💔 API breakage: constructor MethodDescriptor.init(service:method:) has been removed

@gjcairo gjcairo enabled auto-merge (squash) January 17, 2025 17:20
@gjcairo gjcairo mentioned this pull request Jan 17, 2025
Merged
@glbrntt glbrntt disabled auto-merge January 17, 2025 17:28
@glbrntt glbrntt merged commit e4da2bb into grpc:main Jan 17, 2025
30 of 33 checks passed
@gjcairo gjcairo deleted the remove-deprecated branch January 17, 2025 17:28
glbrntt pushed a commit to grpc/grpc-swift-extras that referenced this pull request Jan 20, 2025
@gjcairo
Add GRPCServiceLifecycle module (#29)
0eb173d 
This new module adds conformances to the `Service` protocol from
`grpc-swift-service-lifecycle` to `GRPCClient` and `GRPCServer` so that
they compose nicely with `ServiceLifecycle`.

*Note: depends on grpc/grpc-swift#2166
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glbrntt glbrntt glbrntt approved these changes

Assignees
No one assigned
Labels
⚠️ semver/major Breaks existing public API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gjcairo @glbrntt