Shutdown server gracefully in h2 transport tests #1996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The h2 transport tests cancel the task group running them when the test has completed. Cancelling the server makes apple/swift-nio#2813 more likely to occur. Modifications: - Tell the server to stop listening and let the test stop gracefully Result: Fewer runtime issues
gjcairo
approved these changes
Jul 26, 2024
clintonpi
pushed a commit
to clintonpi/grpc-swift
that referenced
this pull request
Jul 29, 2024
Motivation: The h2 transport tests cancel the task group running them when the test has completed. Cancelling the server makes apple/swift-nio#2813 more likely to occur. Modifications: - Tell the server to stop listening and let the test stop gracefully Result: Fewer runtime issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The h2 transport tests cancel the task group running them when the test has completed. Cancelling the server makes apple/swift-nio#2813 more likely to occur.
Modifications:
Result:
Fewer runtime issues