Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Gus Cairo <[email protected]>
  • Loading branch information
glbrntt and gjcairo authored Dec 20, 2024
1 parent 99f81a8 commit da06969
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions dev/protos/generate.sh
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,6 @@ function generate_reflection_service {
local proto="$here/upstream/grpc/reflection/v1/reflection.proto"
local output="$root/Sources/GRPCReflectionService/Generated"

# Messages were accidentally leaked into public API, they shouldn't be but we
# can't undo that change until the next major version.
generate_message "$proto" "$(dirname "$proto")" "$output" "Visibility=Package" "UseAccessLevelOnImports=true"
generate_grpc "$proto" "$(dirname "$proto")" "$output" "Visibility=Package" "UseAccessLevelOnImports=true"
}
Expand All @@ -126,7 +124,7 @@ function generate_health_service_descriptor_set {
--include_imports
}

function generate_extended_message_descriptor_set {
function generate_base_message_descriptor_set {
local proto="$here/tests/reflection/base_message.proto"
local proto_path="$here/tests/reflection"
local output="$root/Tests/GRPCReflectionServiceTests/Generated/DescriptorSets/base_message.pb"
Expand Down Expand Up @@ -154,5 +152,5 @@ generate_reflection_service

generate_reflection_service_descriptor_set
generate_health_service_descriptor_set
generate_extended_message_descriptor_set
generate_base_message_descriptor_set
generate_message_with_dependency_descriptor_set

0 comments on commit da06969

Please sign in to comment.