Implement grpc.lb.backend_service optional label #11990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This completes gRFC A89. 7162d2d and fc86084 had already implemented the LB plumbing for the optional label on RPC metrics. This observes the value in OpenTelemetry and adds it to WRR metrics as well. https://github.com/grpc/proposal/blob/master/A89-backend-service-metric-label.md
|
@AgraVator, can you take a look? |
AgraVator
reviewed
Apr 16, 2025
Comment on lines
+183
to
+189
| String backendService | ||
| = resolvedAddresses.getAttributes().get(NameResolver.ATTR_BACKEND_SERVICE); | ||
| if (backendService != null) { | ||
| this.backendService = backendService; | ||
| } else { | ||
| this.backendService = ""; | ||
| } |
There was a problem hiding this comment.
can think of exposing a getOrDefault() from the Attributes class
There was a problem hiding this comment.
Technically null could be stored as a value, and then we'd still get null here even with getOrDefault(). Some of our Key classes (but not Attributes) allow choosing a "default" value when it isn't present. That'd probably be better in general than a getOrDefault(). Even if I wanted to do that now, I wouldn't mix it into this PR.
opentelemetry/src/test/java/io/grpc/opentelemetry/OpenTelemetryMetricsModuleTest.java
Show resolved
Hide resolved
Tests shouldn't share constants with code-under-test unless it is the API contract.
AgraVator
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes gRFC A89. 7162d2d and fc86084 had already implemented the LB plumbing for the optional label on RPC metrics. This observes the value in OpenTelemetry and adds it to WRR metrics as well.
https://github.com/grpc/proposal/blob/master/A89-backend-service-metric-label.md