Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds: Make XdsNR.RoutingConfig.empty a constant #11868

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

ejona86
Copy link
Member

@ejona86 ejona86 commented Jan 30, 2025

The field was made final in 4b52639 but was soon reverted in 3ebb3e1 because of what I assume was a bad merge conflict resolution. The field has contained an immutable object since its introduction in d25f5ac, so it is pretty likely to remain a constant in the future.

CC @larry-safran

The field was made final in 4b52639 but was soon reverted in 3ebb3e1
because of what I assume was a bad merge conflict resolution. The field
has contained an immutable object since its introduction in d25f5ac,
so it is pretty likely to remain a constant in the future.
@ejona86 ejona86 merged commit 04f1cc5 into grpc:master Jan 30, 2025
16 checks passed
@ejona86 ejona86 deleted the xds-nr-empty branch January 30, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants