Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use package:web to get HttpStatus #749

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: Use package:web to get HttpStatus #749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1f40f71
Use package:web to get HttpStatus
aran Dec 16, 2024
692bbb2
Merge branch 'master' into web-http-status
mosuem Dec 17, 2024
4df5c4a
docs: add CHANGELOG.md entry
aran Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
the connection, as defined in the gRPC spec.
* Upgrade to `package:lints` version 5.0.0 and Dart SDK version 3.5.0.
* Upgrade `example/grpc-web` code.
* Use `package:web` to get `HttpStatus`

## 4.0.1

Expand Down
2 changes: 1 addition & 1 deletion lib/src/shared/io_bits/io_bits.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@
// See the License for the specific language governing permissions and
// limitations under the License.

export 'io_bits_io.dart' if (dart.library.html) 'io_bits_web.dart';
export 'io_bits_io.dart' if (dart.library.js_interop) 'io_bits_web.dart';
2 changes: 1 addition & 1 deletion lib/src/shared/io_bits/io_bits_web.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

export 'dart:html' show HttpStatus;
export 'package:web/web.dart' show HttpStatus;

/// Unavailable on the web
class InternetAddress {}
Expand Down
1 change: 1 addition & 0 deletions pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ dependencies:
http2: ^2.2.0
protobuf: '>=2.0.0 <4.0.0'
clock: ^1.1.1
web: ^1.1.0

dev_dependencies:
build_runner: ^2.0.0
Expand Down
Loading