fix: Use package:web to get HttpStatus #749
Conversation
PR Health
Breaking changes
|
| Package | Change | Current Version | New Version | Needed Version | Looking good? |
|---|---|---|---|---|---|
| grpc | Non-Breaking | 4.0.1 | 4.0.2-wip | 4.1.0 Got "4.0.2-wip" expected >= "4.1.0" (non-breaking changes) |
This check can be disabled by tagging the PR with skip-breaking-check.
Changelog Entry ✔️
| Package | Changed Files |
|---|
Changes to files need to be accounted for in their respective changelogs.
Coverage ⚠️
| File | Coverage |
|---|---|
| lib/src/shared/io_bits/io_bits.dart | 💔 Not covered |
| lib/src/shared/io_bits/io_bits_web.dart | 💔 Not covered |
This check for test coverage is informational (issues shown here will not fail the PR).
This check can be disabled by tagging the PR with skip-coverage-check.
API leaks ⚠️
The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
| Package | Leaked API symbols |
|---|---|
| grpc | Any $1.Duration |
This check can be disabled by tagging the PR with skip-leaking-check.
You mean the user has to import that himself, right?
At first glance that sounds preferable and less breaking. |
aran
force-pushed
the
web-http-status
branch
from
1e81b1c to
76f1f3f
Compare
Switched. |
aran
force-pushed
the
web-http-status
branch
from
76f1f3f to
1f40f71
Compare
|
LGTM, but please add a changelog and rev the version so that the health check stops complaining :) |
Removes HttpStatus from io_bits, thereby breaking the dependency on dart:html.
Code that previously used HttpStatus from dart:html or dart:io now gets it from package:web.
Alternatively, this could instead use HttpStatus from dart:io on platforms with dart:io and get it from package:web only otherwise. If that's preferred we can do it that way.