Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove canceled streams #661

Merged
merged 7 commits into from
Aug 24, 2023
Merged

Remove canceled streams #661

merged 7 commits into from
Aug 24, 2023

Conversation

mosuem
Copy link
Contributor

@mosuem mosuem commented Aug 22, 2023 •
edited
Loading

To avoid filling up the list with canceled streams.

@mosuem mosuem requested a review from mraleph August 22, 2023 21:07
mraleph
mraleph approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@mraleph mraleph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a suggestion

Are these code paths covered by the existing tests? I can imagine it is a bit hard to actually check for leaks, but at least I want to make sure that cancelation is exercised.

lib/src/server/handler.dart Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/L and removed size/S labels Aug 23, 2023
@mosuem mosuem merged commit 3f05c37 into master Aug 24, 2023
12 checks passed
@mosuem mosuem deleted the closeLeaking branch August 24, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mraleph mraleph mraleph approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mosuem @mraleph