Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh: more datasets and augmentation #61

Closed

Conversation

stephane-rivaud
Copy link
Collaborator

  • refactor SinDataset
  • adding FashionMNIST and SVHN
  • support for AutoAugment and RandAugment

- refactor SinDataset
- adding FashionMNIST and SVHN
- support for AutoAugment and RandAugment
- refactor SinDataset
- adding FashionMNIST and SVHN
- support for AutoAugment and RandAugment
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
unittests 68.07% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/gromo/tools.py 72.46% <ø> (-2.90%) ⬇️

- refactor SinDataset
- adding FashionMNIST and SVHN
- support for AutoAugment and RandAugment
@sylvchev sylvchev added the documentation Improvements or additions to documentation label Feb 13, 2025
Copy link
Collaborator

@sylvchev sylvchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition!

@@ -6,7 +6,7 @@
def sqrt_inverse_matrix_semi_positive(
matrix: torch.Tensor,
threshold: float = 1e-5,
preferred_linalg_library: None | str = "magma",
preferred_linalg_library: None | str = None,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to apply this change as we could assume new hardware and software environment for code execution. We could explicit somewhere that older cuda version may be subject to the bad SVD values.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I removed it because I wanted to try out Stella's solution first.
I always need to do this to test things locally, but we "could" adopt this quick fix if Stella's solution does not work properly.
(So far it does not work properly for me but I need to check if this comes from my setup)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With Pull request #60 I made the config file non-shared so you can create your own and test if it works

@stephane-rivaud
Copy link
Collaborator Author

Outdated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants