updated ClientComplete to do nothing if node is already complete

lib/backbeat/events.rb

@@ -111,10 +111,14 @@ class ClientComplete < Event
       scheduler Schedulers::PerformEvent
 
       def call(node)
-        StateManager.new(node, response).with_rollback do |state|
-          state.transition(current_client_status: :complete, current_server_status: :processing_children)
-          node.mark_complete!
-          Server.fire_event(MarkChildrenReady, node)
+        if !node.complete?
+          StateManager.new(node, response).with_rollback do |state|
+            state.transition(current_client_status: :complete, current_server_status: :processing_children)
+            node.mark_complete!
+            Server.fire_event(MarkChildrenReady, node)
+          end
+        else
+          Logger.info(message: "Node already complete", node: node.id)
         end
       end
     end

spec/unit/events_spec.rb

@@ -256,6 +256,21 @@
       expect(node.current_client_status).to eq("complete")
     end
 
+    it "does nothing if the node is already complete" do
+      node.update_attributes(
+        current_client_status: :complete,
+        current_server_status: :complete
+      )
+
+      expect(Backbeat::Server).to_not receive(:fire_event).with(Backbeat::Events::MarkChildrenReady, node)
+      expect(node).to_not receive(:mark_complete!)
+
+      Backbeat::Events::ClientComplete.call(node)
+
+      expect(node.current_server_status).to eq("complete")
+      expect(node.current_client_status).to eq("complete")
+    end
+
     it "rolls back if error occurs" do
       expect(Backbeat::Server).to receive(:fire_event).with(Backbeat::Events::MarkChildrenReady, node).and_raise "error"
       expect { Backbeat::Events::ClientComplete.call(node) }.to raise_error