Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

68 editar datos del alumno #159

Merged
merged 12 commits into from
Apr 24, 2019
Merged

68 editar datos del alumno #159

merged 12 commits into from
Apr 24, 2019

Conversation

NahuelM426
Copy link
Contributor

@NahuelM426 NahuelM426 commented Apr 14, 2019

Closes #68
hay cosas comentadas en el controller y CargarInscripcionPage que de EstudiosCursados
image

image

image

@NahuelM426 NahuelM426 requested a review from faloi as a code owner April 14, 2019 20:35
@ghost ghost assigned NahuelM426 Apr 14, 2019
@ghost ghost added the review label Apr 14, 2019
@NahuelM426 NahuelM426 requested a review from vgrana April 14, 2019 20:36
Copy link
Contributor

@vgrana vgrana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bajé la rama, y veo que te falta el inscribir cursada a un alumno.

@vgrana
Copy link
Contributor

vgrana commented Apr 14, 2019

Teléfono, a la hora de editarlo, trae el campo vacio;
Me parece que la carrera no debería editarse, sino mostrarse

@vgrana vgrana self-requested a review April 14, 2019 23:48
Copy link
Contributor

@vgrana vgrana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recordar que hay código comentado
Ver definición de si la carrera en la que está inscripto el alumno debería poder editarse

Copy link
Contributor

@faloi faloi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me parece bien que la carrera pueda editarse, aunque deberíamos agregar una validación que no permita hacerlo si ya está cursando alguna materia. Lo pongo en una issue: #160.

Como dijo @vgrana, borrá el código comentado y mergeamos.

@NahuelM426
Copy link
Contributor Author

NahuelM426 commented Apr 15, 2019 via email

@faloi
Copy link
Contributor

faloi commented Apr 23, 2019

Resolvé los conflictos y mergeá, ya está aprobado.

@faloi faloi merged commit 2b0f913 into master Apr 24, 2019
@faloi faloi deleted the 68-editar-datos-del-alumno branch April 24, 2019 22:51
@ghost ghost added production and removed review labels Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editar datos del alumno
3 participants