137 validar que un alumno puede inscribirse a una materia #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riz-digital into 137-validar-que-un-alumno-puede-inscribirse-a-una-materia
…vas, visualizando el error en la vista
ghost
assigned 
JuanCS95
approved these changes
Apr 8, 2019
faloi
suggested changes
Apr 8, 2019
| this.cursadas.add(cursada); | ||
| } | ||
|
|
||
| public void addCursadaComprobandoCorrelativas(Cursada cursada, Materia materia) { |
There was a problem hiding this comment.
¿Por qué un método aparte? La idea es que nunca se pueda agregar una cursada inválida, y el código del modelo no debe permitirlo.
El parámetro materia no deberías necesitarlo, porque ya está dentro de la cursada.
There was a problem hiding this comment.
Tenes razón Fede, ya lo corregí. Buena observación.
| if(!this.puedeMatricularseA(materia)){ | ||
| throw new ModelException("No puede matricularse en la materia " | ||
| + materia.getNombre() + | ||
| " porque debe sus correlativas."); |
There was a problem hiding this comment.
Estaría bueno mostrar cuáles debe. Lo dejamos para otra issue: #151.
| public class CorrelativaTest { | ||
|
|
||
| @Test | ||
| public void agregarCorrelativaandaTest(){ |
There was a problem hiding this comment.
Este test solo prueba que anda el método addCorrelativa de las materias, lo cual no nos dice nada sobre lo que hiciste.
Yo haría estos tests:
- un alumno que tiene las correlativas, se anota a la materia y no pasa nada.
- un alumno que no tiene las correlativas, intenta anotarse a la materia y tira error.
…riz-digital into 137-validar-que-un-alumno-puede-inscribirse-a-una-materia
…ógica paso a addCursada()
…CursarMateriaConCorrelativa()
faloi
approved these changes
Apr 15, 2019
faloi
deleted the
137-validar-que-un-alumno-puede-inscribirse-a-una-materia
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #137
Validación cuando un alumno intenta cursar una materia que tiene correlativas y todavía no las hizo(rindió o regularizó).
Tiene hecho un test para comprobar que el método de validación funciona.