Allow SDK methods to accept request_timeout through kwargs
#332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoreyEWood
commented
Mar 17, 2025
Comment on lines
282
to
+284
| def get_detector_by_name(self, name: str) -> Detector: | ||
| # TODO should methods like this (which make direct requests instead of going through the API) allow | ||
| # kwargs to be passed through? |
There was a problem hiding this comment.
Here's one type of tricky case for allowing request_timeout to be specified.
CoreyEWood
commented
Mar 18, 2025
| @@ -960,6 +986,9 @@ def wait_for_confident_result( | |||
| confidence_threshold: Optional[float] = None, | |||
| timeout_sec: float = 30.0, | |||
| ) -> ImageQuery: | |||
| # TODO should this method allow request_timeout to be passed in kwargs? | |||
| # It's a weird case because it might make multiple requests - would the specified request_timeout be applied | |||
| # to each request? | |||
There was a problem hiding this comment.
This is another tricky case for accepting request_timeout.
CoreyEWood
commented
Mar 18, 2025
There was a problem hiding this comment.
An overall question: is there a sensible way to test this for all the methods we want to enable request_timeout through kwargs for?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.