Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRDB 7: Migration Guide #1638

Merged
merged 17 commits into from
Sep 28, 2024
Merged

GRDB 7: Migration Guide #1638

merged 17 commits into from
Sep 28, 2024

Commits on Sep 22, 2024

  1. Fixits

    groue committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    f7d85b0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ef2251e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2800530 View commit details
    Browse the repository at this point in the history
  4. GRDB 7 migration guide

    groue committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    48cb4cf View commit details
    Browse the repository at this point in the history
  5. Swift Concurrency Guide WIP

    groue committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    7f1a3fd View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    aa7c528 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. TODO

    groue committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    5d44fc7 View commit details
    Browse the repository at this point in the history
  2. SwiftConcurrency.md

    groue committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    e7e5956 View commit details
    Browse the repository at this point in the history
  3. GRDB7MigrationGuide.md

    groue committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    ebe313c View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. SwiftConcurrency.md

    groue committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    bc98fdb View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Configuration menu
    Copy the full SHA
    521d784 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. SwiftConcurrency.md

    groue committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    cb001cb View commit details
    Browse the repository at this point in the history
  2. SwiftConcurrency.md

    ChatGPT remarks:
    
    # Overview Section:
    
    The phrase "GRDB optimally schedules those database access closures, in the best interest of the application" is vague and could benefit from more detail on how the scheduling optimizes for concurrency.
    
    # Concurrency Warnings in Swift 6:
    
    "We will address these issues, and provide general guidance in the following sections." This sentence suggests that detailed solutions will be discussed, but it is unclear how each error is related to the following section titles. A more specific reference to which section will cover what would help orient the reader.
    
    # Non-Sendable Record Types Section:
    
    The FAQ format is useful, but it could overwhelm the reader. Breaking up the FAQ into subsections with more concise answers or reordering it based on common issues could improve readability.
    
    # Shorthand Closure Notation Section:
    
    The explanation of why shorthand notation leads to warnings is somewhat technical. It may be helpful to clarify what "may introduce data races" means in practical terms for less experienced developers.
    
    # Choosing Between Synchronous and Asynchronous Database Access:
    
    The section recommends using asynchronous access but leaves open-ended guidance like "this may slow down other tasks". Adding a more concrete explanation of how to balance performance between synchronous and asynchronous approaches would benefit developers.
    
    # General Clarification on Sendable:
    
    Throughout the document, Sendable is mentioned frequently, but less-experienced developers might not fully understand why it matters. A short section or footnote on what Sendable is and why it’s important in Swift 6 concurrency might help provide context for readers unfamiliar with the concept.
    groue committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    9b6a3b9 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. SwiftConcurrency.md

    groue committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    8dbce53 View commit details
    Browse the repository at this point in the history
  2. TODO

    groue committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    d003601 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b389547 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2024

  1. Fix SPM CI tests

    groue committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    ebdd1f1 View commit details
    Browse the repository at this point in the history