-
-
Notifications
You must be signed in to change notification settings - Fork 711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GRDB 7: Migration Guide #1638
Merged
Merged
GRDB 7: Migration Guide #1638
Commits on Sep 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f7d85b0 - Browse repository at this point
Copy the full SHA f7d85b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for ef2251e - Browse repository at this point
Copy the full SHA ef2251eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2800530 - Browse repository at this point
Copy the full SHA 2800530View commit details -
Configuration menu - View commit details
-
Copy full SHA for 48cb4cf - Browse repository at this point
Copy the full SHA 48cb4cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f1a3fd - Browse repository at this point
Copy the full SHA 7f1a3fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for aa7c528 - Browse repository at this point
Copy the full SHA aa7c528View commit details
Commits on Sep 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5d44fc7 - Browse repository at this point
Copy the full SHA 5d44fc7View commit details -
Configuration menu - View commit details
-
Copy full SHA for e7e5956 - Browse repository at this point
Copy the full SHA e7e5956View commit details -
Configuration menu - View commit details
-
Copy full SHA for ebe313c - Browse repository at this point
Copy the full SHA ebe313cView commit details
Commits on Sep 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for bc98fdb - Browse repository at this point
Copy the full SHA bc98fdbView commit details
Commits on Sep 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 521d784 - Browse repository at this point
Copy the full SHA 521d784View commit details
Commits on Sep 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for cb001cb - Browse repository at this point
Copy the full SHA cb001cbView commit details -
ChatGPT remarks: # Overview Section: The phrase "GRDB optimally schedules those database access closures, in the best interest of the application" is vague and could benefit from more detail on how the scheduling optimizes for concurrency. # Concurrency Warnings in Swift 6: "We will address these issues, and provide general guidance in the following sections." This sentence suggests that detailed solutions will be discussed, but it is unclear how each error is related to the following section titles. A more specific reference to which section will cover what would help orient the reader. # Non-Sendable Record Types Section: The FAQ format is useful, but it could overwhelm the reader. Breaking up the FAQ into subsections with more concise answers or reordering it based on common issues could improve readability. # Shorthand Closure Notation Section: The explanation of why shorthand notation leads to warnings is somewhat technical. It may be helpful to clarify what "may introduce data races" means in practical terms for less experienced developers. # Choosing Between Synchronous and Asynchronous Database Access: The section recommends using asynchronous access but leaves open-ended guidance like "this may slow down other tasks". Adding a more concrete explanation of how to balance performance between synchronous and asynchronous approaches would benefit developers. # General Clarification on Sendable: Throughout the document, Sendable is mentioned frequently, but less-experienced developers might not fully understand why it matters. A short section or footnote on what Sendable is and why it’s important in Swift 6 concurrency might help provide context for readers unfamiliar with the concept.
Configuration menu - View commit details
-
Copy full SHA for 9b6a3b9 - Browse repository at this point
Copy the full SHA 9b6a3b9View commit details
Commits on Sep 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8dbce53 - Browse repository at this point
Copy the full SHA 8dbce53View commit details -
Configuration menu - View commit details
-
Copy full SHA for d003601 - Browse repository at this point
Copy the full SHA d003601View commit details -
Configuration menu - View commit details
-
Copy full SHA for b389547 - Browse repository at this point
Copy the full SHA b389547View commit details
Commits on Sep 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ebdd1f1 - Browse repository at this point
Copy the full SHA ebdd1f1View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.