GRDB 7: Prefer Collection over Sequence for filter(keys:) and related APIs
#1617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ved APIs We were frequently turning those sequences into an Array in order to check their emptiness, and generally were not sure we'd iterate a sequence only once. Also use `some Sequence` and `some Collection` whenever possible.
groue
force-pushed
the
dev/GRDB7-collection-over-sequence
branch
from
7fc2ea9
to
6a29d6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some apis such as
filter(key:)which used to accept aSequencenow require aCollection.