Fix compilation issue with Xcode 16 beta 5 due to a missing import. #1589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@groue I'm handling this while you're asleep ;) |
|
How far we are to this be merged? |
|
Thank you @noremac 👍 @layoutSubviews, I was indeed asleep :-) Thanks for running the CI. Did you plan to ship 6.29.1, and did you meet an unexpected stopper? The release process is partially documented. It does not describe the merge/commit dance (I usually just look at how I did the previous release), and it is over-correct (this PR has no impact on the public API so many checks can just be skipped). I'm downloading beta 5 right now, and I'll ship 6.29.1 shortly. |
|
Shipped in 6.29.1. Thank you all! |
takasurazeem
added a commit
to takasurazeem/quran-ios
that referenced
this pull request
Aug 25, 2024
The issue is fixed with this PR (groue/GRDB.swift#1589), I am going to update the version to latest of GRDB released yesterday which is 6.29.2 ان شاء اللہ تَعَالٰی Closes quran#652
mohamede1945
pushed a commit
to quran/quran-ios
that referenced
this pull request
Aug 25, 2024
The issue is fixed with this PR (groue/GRDB.swift#1589), I am going to update the version to latest of GRDB released yesterday which is 6.29.2 ان شاء اللہ تَعَالٰی Closes #652
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #1588, a compilation issue with Xcode 16 beta 5.
Pull Request Checklist
developmentbranch.make smokeTestterminal command runs without failure.