Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential UI glitch when transport type is not given #894

Closed
wants to merge 3 commits into from
Closed

Fix potential UI glitch when transport type is not given #894

wants to merge 3 commits into from

Conversation

Altonss
Copy link
Collaborator

@Altonss Altonss commented Dec 6, 2023

Fixes #827

@Altonss Altonss requested a review from ialokim December 6, 2023 11:30
@cla-bot cla-bot bot added the cla-signed ✔️ The Contributor Licence Agreement was signed by all contributors. label Dec 6, 2023
@Altonss Altonss requested a review from pt2121 December 6, 2023 11:34
ialokim
ialokim reviewed Jan 4, 2024
View reviewed changes
Copy link
Collaborator

@ialokim ialokim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix!

app/src/main/res/drawable/product_null.xml Show resolved Hide resolved
@Altonss Altonss mentioned this pull request Jan 7, 2024
Merged
11 tasks
@Altonss Altonss removed the request for review from pt2121 January 10, 2024 18:55
@ialokim
Copy link
Collaborator

ialokim commented Feb 7, 2024

Thanks for posting a screenshot, looks good indeed. But I'm still not fully convinced by the empty icon, feels a bit like a hack. I think the cleaner solution would be to change the layout file that defines the product view to ensure it works even without an icon.

@Altonss do you feel like looking into the layout file again?

@Altonss
Copy link
Collaborator Author

Altonss commented Feb 13, 2024

Thanks for posting a screenshot, looks good indeed. But I'm still not fully convinced by the empty icon, feels a bit like a hack. I think the cleaner solution would be to change the layout file that defines the product view to ensure it works even without an icon.

@Altonss do you feel like looking into the layout file again?

I will try to give it a look :)

@Altonss Altonss closed this May 12, 2024
@Altonss Altonss deleted the fixUI-noProductInfo branch May 12, 2024 13:51
@Altonss Altonss mentioned this pull request May 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ialokim ialokim ialokim left review comments

Assignees
No one assigned
Labels
cla-signed ✔️ The Contributor Licence Agreement was signed by all contributors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Potential UI glitch when transport type is not given
2 participants
@Altonss @ialokim