Kaarolch kch/slo time slice #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kaarolch lmk if there are any gotchas missing ... seems to mostly work from my limited testing with 1 new timeslice slo🤞 |
grosser
force-pushed
the
kaarolch-kch/slo_time_slice
branch
2 times, most recently
from
45047c9
to
a8f7c5a
Compare
|
I had to change the test too because the example json was not correct (was not what the importer spat out for my example) |
grosser
commented
May 25, 2024
| TITLES = [:name, :title].freeze | ||
| SORT_ORDER = [*TITLES, :id, :kennel_id, :type, :tags, :query, *Models::Record.subclasses.map { |k| k::TRACKING_FIELDS }, :template_variables].freeze |
There was a problem hiding this comment.
FYI this had an unrelated bug too where we needed flat_map because TRACKING_FIELDS can have multiple entries
grosser
commented
May 25, 2024
| READONLY_ATTRIBUTES = [ | ||
| *superclass::READONLY_ATTRIBUTES, | ||
| :type_id, :monitor_tags, :target_threshold, :timeframe, :warning_threshold | ||
| ].freeze |
There was a problem hiding this comment.
this missing freeze was hiding the issue with the importer removing sli_specification during normalize (we added sli_specification to READONLY_ATTRIBUTES in a local hack)
kaarolch
approved these changes
May 27, 2024
|
I've tested it in the local branch and object was correctly imported and also json was generated. :ty |
|
v1.152.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rake generatenot producing tons of diffrake plannot producing tons of diff