Skip to content

Commit

Permalink
RnP: Fix bitrate in screenshare.yml
Browse files Browse the repository at this point in the history
I forgot to include the 'K' multiplier on the bitrate values, so they
were all 1000 times too low.
  • Loading branch information
kepstin committed May 11, 2018
1 parent 2ceaa40 commit 32ff8b9
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions record-and-playback/screenshare/scripts/screenshare.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ formats:
- [ '-pass', '1',
# Video
'-c:v', 'libvpx-vp9',
'-crf', '32', '-b:v', '1024', '-minrate', '512', '-maxrate', '1485',
'-crf', '32', '-b:v', '1024K', '-minrate', '512K', '-maxrate', '1485K',
'-quality', 'good', '-speed', '4', '-g', '240',
'-tile-columns', '2', '-threads', '8',
# Disable audio in first pass
Expand All @@ -35,7 +35,7 @@ formats:
- [ '-pass', '2',
# Video
'-c:v', 'libvpx-vp9',
'-crf', '32', '-b:v', '1024', '-minrate', '512', '-maxrate', '1485',
'-crf', '32', '-b:v', '1024K', '-minrate', '512K', '-maxrate', '1485K',
'-quality', 'good', '-speed', '2', '-g', '240',
'-tile-columns', '2', '-threads', '8',
# Audio
Expand All @@ -45,7 +45,7 @@ formats:
'-f', 'webm' ]
# Single-pass encoding - faster, lower quality
# - [ '-c:v', 'libvpx-vp9',
# '-crf', '32', '-b:v', '1024', '-minrate', '512', '-maxrate', '1485',
# '-crf', '32', '-b:v', '1024K', '-minrate', '512K', '-maxrate', '1485K',
# '-quality', 'good', '-speed', '4', '-g', '240',
# '-tile-columns', '2', '-threads', '8',
# '-c:a', 'libopus',
Expand Down

0 comments on commit 32ff8b9

Please sign in to comment.