Skip to content

Commit

Permalink
Recording: Remove the red5 race workaround that delays processing
Browse files Browse the repository at this point in the history
This was added to workaround for red5 taking a while to rewrite the
serialized (.ser) data that it streams to disk back to the .flv format.

The workaround is no longer needed, for two reasons:
* The sanity scripts run the red5 code to generate the .flv from the .ser
  if needed, and
* We're expecting more people to be using WebRTC media in the future anyways

This makes recordings available up to 2 minutes earlier than they would have
been otherwise.
  • Loading branch information
kepstin committed Feb 28, 2019
1 parent 44663a8 commit 010153c
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions record-and-playback/core/scripts/rap-archive-worker.rb
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,6 @@
require 'yaml'
require 'fileutils'

# Number of seconds to delay archiving (red5 race condition workaround)
ARCHIVE_DELAY_SECONDS = 120

def archive_recorded_meetings(recording_dir)
recorded_done_files = Dir.glob("#{recording_dir}/status/recorded/*.done")

Expand All @@ -45,11 +42,6 @@ def archive_recorded_meetings(recording_dir)
next
end

if File.mtime(recorded_done) + ARCHIVE_DELAY_SECONDS > Time.now
BigBlueButton.logger.info("Temporarily skipping #{recorded_done_base} for Red5 race workaround")
next
end

archived_done = "#{recording_dir}/status/archived/#{recorded_done_base}.done"
next if File.exists?(archived_done)

Expand Down

0 comments on commit 010153c

Please sign in to comment.