Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added suggested columns from #79 #105

Merged
merged 1 commit into from
Dec 28, 2022
Merged

Added suggested columns from #79 #105

merged 1 commit into from
Dec 28, 2022

Conversation

snipe
Copy link
Member

@snipe snipe commented Dec 9, 2022

This isn't so much a code fix as it is an example fix. Addresses #79.

Signed-off-by: snipe [email protected]

ParadoxGuitarist
ParadoxGuitarist reviewed Dec 9, 2022
View reviewed changes
Copy link
Collaborator

@ParadoxGuitarist ParadoxGuitarist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart. I like it. But Can it actually divide the ram MB like that? I remember a request for that feature coming in, but I don't know if it actually works that way. If it does, lgtm.

@snipe
Copy link
Member Author

snipe commented Dec 14, 2022

Seems like it? I dunno, I don't write Python lol

#79 (comment)

@ParadoxGuitarist ParadoxGuitarist merged commit 8d2b966 into main Dec 28, 2022
@ParadoxGuitarist ParadoxGuitarist deleted the fixes/added_example_column_math_in_settings_example branch December 28, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ParadoxGuitarist ParadoxGuitarist ParadoxGuitarist approved these changes

@uberbrady uberbrady Awaiting requested review from uberbrady

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snipe @ParadoxGuitarist