feat(thermostat): Add refresh fetch attempts. #426
Conversation
| @@ -564,6 +608,21 @@ export class SystemConfigModel extends BaseSystemModel { | |||
| } | |||
| } | |||
|
|
|||
| export class SystemModelSettings { | |||
There was a problem hiding this comment.
Originally had this as SystemModelConfig...but that seems to close to SystemConfigModel :)
|
Hey! Thanks for putting up this PR! I'll take a look over the weekend. I do have a pretty significant refactor in progress to add the polling and pushing to homekit I mentioned, so I need to see how this will interact with those changes. |
|
Sorry for the delay here! The retry logic here looks good, but I don't want to expose new settings right now, since I am hoping the push based version will make the refresh better so we don't need retries. So for this PR, maybe lets hardcode the stale threshold and retry count? (Alternatively, I just put a beta version of the push logic out. I'm not ready to push it to stable yet, but feel free to also give this a try and see if it refreshes better for you.) |
@grivkees This is my first time with TS so please feel free to nitpick. I'm adding support to the fetch operation to wait for current data from the thermostat before returning. I added configuration options so folks can tweak it how they desire. I've found it takes ~3 seconds for new data to show up in the API.