Skip to content

Commit

Permalink
vdso: remove empty note section
Browse files Browse the repository at this point in the history
An empty note section looks weird and can confuse some tools. For example,
we've seen this in https://reviews.llvm.org/D116639.

PiperOrigin-RevId: 420093551
  • Loading branch information
avagin authored and gvisor-bot committed Jan 6, 2022
1 parent d1dae8d commit aa06a0c
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
3 changes: 0 additions & 3 deletions vdso/vdso_amd64.lds
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,6 @@ SECTIONS {
.gnu.version_d : { *(.gnu.version_d) }
.gnu.version_r : { *(.gnu.version_r) }

.note : { *(.note.*) } :text :note

.eh_frame_hdr : { *(.eh_frame_hdr) } :text :eh_frame_hdr
.eh_frame : { KEEP (*(.eh_frame)) } :text

Expand Down Expand Up @@ -77,7 +75,6 @@ SECTIONS {
PHDRS {
text PT_LOAD FLAGS(5) FILEHDR PHDRS; /* PF_R | PF_X */
dynamic PT_DYNAMIC FLAGS(4); /* PF_R */
note PT_NOTE FLAGS(4); /* PF_R */
eh_frame_hdr PT_GNU_EH_FRAME;
}

Expand Down
3 changes: 0 additions & 3 deletions vdso/vdso_arm64.lds
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,6 @@ SECTIONS {
.gnu.version_d : { *(.gnu.version_d) }
.gnu.version_r : { *(.gnu.version_r) }

.note : { *(.note.*) } :text :note

.eh_frame_hdr : { *(.eh_frame_hdr) } :text :eh_frame_hdr
.eh_frame : { KEEP (*(.eh_frame)) } :text

Expand Down Expand Up @@ -80,7 +78,6 @@ SECTIONS {
PHDRS {
text PT_LOAD FLAGS(5) FILEHDR PHDRS; /* PF_R | PF_X */
dynamic PT_DYNAMIC FLAGS(4); /* PF_R */
note PT_NOTE FLAGS(4); /* PF_R */
eh_frame_hdr PT_GNU_EH_FRAME;
}

Expand Down

0 comments on commit aa06a0c

Please sign in to comment.