-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow marking translations reviewed #392
base: master
Are you sure you want to change the base?
Allow marking translations reviewed #392
Conversation
✅ Deploy Preview for grist-help-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Might it be better to put such a marker into each page's meta data (https://www.mkdocs.org/user-guide/writing-your-docs/#yaml-style-meta-data)? |
@dsagal I originally abandoned this idea: Git localize detects these metadata, so it would be expected that this property appears in both English and French (or any other language). I thought it would not be convenient, as the original writers (of the English version) have to keep in mind adding this property in the metadata. But thinking again, what do you think of introducing a new command that does the following?
We could make this run in Github actions every 24h, and/or on push on master, and/or when triggered manually (with a PR if some files have been updated). The advantages are that:
The tricky part is that translators should keep track of the changes made in the English documentation (unless we find a way to tell GPT to only detect and translate parts of the documents that have been changed without overriding the existing reviewed translations). Something I still need to think of. For the scope of this PR, I suggest that I put aside the machine translation and only make this command add the |
Working on an idea, for now changing it to draft. |
Waiting for #396 to be merged before reopening and working again on this PR |
When machine translations have been modified and reviewed, there is no need anymore to show this warning:
https://github.com/gristlabs/grist-help/blob/master/help/fr/MACHINE-TRANSLATION.md
I propose to add to the mkdocs.yml an extra config to mark translations as being reviewed.