Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for Extreme Networks AP3825i #7

Merged
merged 4 commits into from
Nov 20, 2023
Merged

add support for Extreme Networks AP3825i #7

merged 4 commits into from
Nov 20, 2023

Conversation

grische
Copy link
Owner

@grische grische commented Nov 19, 2023

No description provided.

@grische grische force-pushed the feature/ws3825i branch 3 times, most recently from 319c62b to 58a3333 Compare November 19, 2023 13:47
@grische grische marked this pull request as ready for review November 19, 2023 14:37
@grische grische self-assigned this Nov 19, 2023
@grische grische added the enhancement New feature or request label Nov 19, 2023
istrator2
istrator2 suggested changes Nov 19, 2023
View reviewed changes
Copy link
Contributor

@istrator2 istrator2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks overall good, but you want to fix always True condition.

extremeflash/ws_ap3825i.py Outdated Show resolved Hide resolved
@grische
Copy link
Owner Author

grische commented Nov 19, 2023

Also added a new commit with improved boot paramters.

istrator2
istrator2 approved these changes Nov 19, 2023
View reviewed changes
Copy link
Contributor

@istrator2 istrator2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'm not worried about.

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
istrator2
istrator2 approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@istrator2 istrator2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for clarification

grische and others added 4 commits November 21, 2023 00:28
@grische
add support for Extreme Networks AP3825i
4a67ff6 
Re-using most functions from ws_ap3710i until we can do a proper split.
@grische
ap3825i: use more resilient boot_openwrt_params
9666212 
Based on https://forum.darmstadt.freifunk.net/t/flashing-of-the-extreme-networks-ws-ap3825i/923
@grische
readme: add notes for AP3825-related changes
0a8ddc6 
- Add a note that LAN port 1 cannot be used for flashing on an access
  point with multiple LAN ports.
- Add --model parameter to examples
- Change installation to use AP3710i only as an example
@grische
readme: add a note about matching image versions
3a55364
@grische grische merged commit 51e4fa3 into main Nov 20, 2023
4 checks passed
@grische grische deleted the feature/ws3825i branch November 20, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@istrator2 istrator2 istrator2 approved these changes

Assignees

@grische grische

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grische @istrator2