Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(drivers): add GriptapeCloudPromptDriver #1692

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

collindutter
Copy link
Member

@collindutter collindutter commented Feb 11, 2025

Describe your changes

Adds GriptapeCloudPromptDriver.

Issue ticket number and link

NA

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 94.23077% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ape/drivers/prompt/griptape_cloud_prompt_driver.py 93.87% 0 Missing and 3 partials ⚠️

📢 Thoughts on this report? Let us know!

@collindutter collindutter added this to the 1.4 milestone Feb 11, 2025
@collindutter collindutter force-pushed the feature/griptape-cloud-prompt-driver branch 6 times, most recently from 8ec9132 to 94023fd Compare February 12, 2025 20:00
@collindutter collindutter self-assigned this Feb 13, 2025
@collindutter collindutter force-pushed the feature/griptape-cloud-prompt-driver branch 2 times, most recently from 3b1f9ec to 0f1a834 Compare February 17, 2025 21:17
@collindutter collindutter marked this pull request as ready for review February 18, 2025 21:06
@collindutter collindutter force-pushed the feature/griptape-cloud-prompt-driver branch from 0f1a834 to 4f40645 Compare February 18, 2025 21:06
@collindutter collindutter marked this pull request as draft February 18, 2025 21:06
@collindutter collindutter force-pushed the feature/griptape-cloud-prompt-driver branch 4 times, most recently from 2aa3811 to 542878e Compare February 19, 2025 00:28
@collindutter collindutter marked this pull request as ready for review February 19, 2025 00:34
@collindutter collindutter force-pushed the feature/griptape-cloud-prompt-driver branch from 542878e to 61626e1 Compare February 19, 2025 00:36
},
}

def __to_griptape_tools__(self, tools: list[BaseTool]) -> list[dict]:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldnt this be __to_griptape_tools for the python auto-private-method-mangling?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know where those trailing __s came from, removed.

@collindutter collindutter force-pushed the feature/griptape-cloud-prompt-driver branch 2 times, most recently from fedb08c to 222c055 Compare February 19, 2025 03:14
@collindutter collindutter force-pushed the feature/griptape-cloud-prompt-driver branch 2 times, most recently from f2be8b3 to 377e958 Compare February 20, 2025 23:08
@collindutter collindutter force-pushed the feature/griptape-cloud-prompt-driver branch from 377e958 to 7f86964 Compare February 20, 2025 23:11
@collindutter collindutter added this pull request to the merge queue Feb 21, 2025
@collindutter collindutter removed this pull request from the merge queue due to a manual request Feb 21, 2025
@collindutter collindutter force-pushed the feature/griptape-cloud-prompt-driver branch from 7f86964 to 64270e4 Compare February 21, 2025 00:34
@collindutter collindutter added this pull request to the merge queue Feb 21, 2025
Merged via the queue into main with commit 7af49da Feb 21, 2025
16 checks passed
@collindutter collindutter deleted the feature/griptape-cloud-prompt-driver branch February 21, 2025 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants