Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update amazon_bedrock_tokenizer.py #1654

Merged
merged 10 commits into from
Feb 10, 2025
Merged

Conversation

ennio1991
Copy link
Contributor

@ennio1991 ennio1991 commented Feb 6, 2025

Included nova models and fixed minor issues

Describe your changes

Issue ticket number and link

Included nova models and fixed minor issues
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link
Member

@collindutter collindutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thank you @ennio1991!

griptape/tokenizers/amazon_bedrock_tokenizer.py Outdated Show resolved Hide resolved
griptape/tokenizers/amazon_bedrock_tokenizer.py Outdated Show resolved Hide resolved
Copy link
Member

@collindutter collindutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found another round of reductions. Thanks for working with me on this :)

griptape/tokenizers/amazon_bedrock_tokenizer.py Outdated Show resolved Hide resolved
griptape/tokenizers/amazon_bedrock_tokenizer.py Outdated Show resolved Hide resolved
griptape/tokenizers/amazon_bedrock_tokenizer.py Outdated Show resolved Hide resolved
griptape/tokenizers/amazon_bedrock_tokenizer.py Outdated Show resolved Hide resolved
griptape/tokenizers/amazon_bedrock_tokenizer.py Outdated Show resolved Hide resolved
@ennio1991
Copy link
Contributor Author

Sure, thanks @collindutter

@collindutter collindutter added this pull request to the merge queue Feb 10, 2025
Merged via the queue into griptape-ai:main with commit c9441fd Feb 10, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants