Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(drivers-prompt-openai):add audio input/output support to OpenAiChatPromptDriver #1617

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(drivers-prompt-openai):add audio input/output support to OpenAiChatPromptDriver #1617

wants to merge 1 commit into from

Conversation

collindutter
Copy link
Member

@collindutter collindutter commented Jan 24, 2025 •
edited
Loading

Describe your changes

Added

  • Support for AudioArtifact inputs/outputs in OpenAiChatPromptDriver.

Issue ticket number and link

Closes #1601

@collindutter collindutter mentioned this pull request Jan 29, 2025
Merged
1 task
@collindutter collindutter force-pushed the feature/openai-audio branch 2 times, most recently from efa0532 to 7c77f8d Compare January 29, 2025 23:25
@codecov Codecov
Copy link

codecov bot commented Jan 29, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.55172% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...iptape/drivers/prompt/openai_chat_prompt_driver.py 93.33% 0 Missing and 2 partials ⚠️
griptape/tasks/prompt_task.py 80.00% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@collindutter collindutter force-pushed the feature/openai-audio branch 2 times, most recently from 5f9394f to 73e246a Compare January 30, 2025 00:03
@collindutter
Copy link
Member Author

collindutter commented Jan 30, 2025 •
edited
Loading

Still need docs, code is ready for review though.

@collindutter collindutter requested a review from vachillo January 30, 2025 00:15
@collindutter collindutter marked this pull request as ready for review January 30, 2025 00:15
@collindutter collindutter force-pushed the feature/openai-audio branch 2 times, most recently from 442d68f to f26f6b3 Compare February 4, 2025 17:53
@collindutter collindutter force-pushed the feature/openai-audio branch 2 times, most recently from 37f793f to f023372 Compare February 5, 2025 02:02
@collindutter collindutter changed the title OpenAi Audio Inputs/Outputs feat(drivers-prompt-openai):add audio input/output support to OpenAiChatPromptDriver Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylanholmes dylanholmes Awaiting requested review from dylanholmes

@vachillo vachillo Awaiting requested review from vachillo

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support OpenAi Audio Inputs/Outputs
1 participant
@collindutter