Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Activity Feed #1012

Merged
merged 80 commits into from
Oct 18, 2024
Merged

WIP: Activity Feed #1012

merged 80 commits into from
Oct 18, 2024

Conversation

jmcmichael
Copy link
Contributor

@jmcmichael jmcmichael commented Mar 7, 2024 •
edited
Loading

Replaces the Event Feed components with an Activity Feed. This is a draft PR to coordinate merging and to keep track of outstanding todos.

Detailed Activity Components

All the activity detail components have been created, but require template work to be useful:

  • accept-revisions
  • comment
  • create-molecular-profile
  • create-variant
  • deprecate-molecular-profile
  • deprecate-variant
  • flag-entity
  • moderate-assertion
  • moderate-evidence
  • reject-revisions
  • resolve-flag
  • sumbit-assertion
  • submit-evidence
  • suggest-revisions
  • suggest-source
  • update-source-suggestion

Misc. Feed Features

  • query error notification & details
  • empty results with specified filters message
  • end-of results notification
  • toggle tag popovers off when scrolling
  • feed polling
  • rewrite verbiage to work better with header content

@jmcmichael
updating typescript, zone.js as per v16->v17 checklist
13bcdb0
@jmcmichael
angular updated to v17.0.10
fd1ed85
@jmcmichael
post db:migrate schema.rb updates
00d7bd7
@jmcmichael
updated ng-zorro-antd -> v17.1.0
0600bfb
@jmcmichael
ngrx-component updated v16 -> v17
25f1719
@jmcmichael
fixed sidebar menu for updated zorro dark styles
ee9b674
@jmcmichael
downgraded zorro, to v17.0.0, latest has missing tbody style bug (see…
c505220 
… #8352)
@jmcmichael
replaced old activity-feed component
80d816d
@jmcmichael
set up parameters, filters, fetch/refetch observables, queries
d6152f4
@jmcmichael
feedPrefs Inputs working with OnChanges & refetch query
3364fcd
@jmcmichael
feedInfo Output working
bb02dc9
@jmcmichael
activity-item component boilerplate
88e2178
@jmcmichael
all setting, filters inputs working w/ queries
0cd0ee6
@jmcmichael
implemented as nz-list with nzGrid layout
fe1b402
@jmcmichael
feed settings, filters, counts components working
807b992
@jmcmichael
Merge branch 'main' into merge-filters
2b24580
@jmcmichael
Merge remote-tracking branch 'origin/activity-feed-filters' into merg…
467f139 
…e-filters
@jmcmichael
componentized feed-settings
4ecb71f
@jmcmichael
updated ng 17.0.0 -> 17.1.1
bffdcfd
@jmcmichael
Merge branch 'main' into activity-feed-v2
c001189
@jmcmichael
componentized activity-feed card
999063e
@jmcmichael
subscribable subject filter working
f7c072f
@jmcmichael
filter lists display layout working
b3b69ab
@jmcmichael
filter select, clear, 'show all' option working
594d6c3
@jmcmichael
Merge remote-tracking branch 'origin/activity-feed-filters' into acti…
c26a623 
…vity-feed-v2
@jmcmichael
Merge remote-tracking branch 'origin/activity-feed-filters' into acti…
f7dc6f6 
…vity-feed-v2
@jmcmichael
Merge remote-tracking branch 'origin/activity-feed-filters' into acti…
4f5b819 
…vity-feed-v2
@jmcmichael
Merge remote-tracking branch 'origin/activity-feed-filters' into acti…
380c512 
…vity-feed-v2
@jmcmichael
regenerated apollo client from updated server schema
7858ba9
@jmcmichael
refactor feed for activities() query & better component architecture
3738793
jmcmichael and others added 21 commits February 21, 2024 11:54
@jmcmichael
moved some utility functions to activity-feed.functions
fa30186
@jmcmichael
ngx-ui-scroll fetchMore working properly
120ae90
@jmcmichael
feed item counts, scroller reset on filter refetch query
8e9ff29
@jmcmichael
Merge branch 'activity-feed-v2--infinite-scroll' into activity-feed-v2
ae40b7a
@jmcmichael
switched to using nz-card for feed-items, added tags to item titles
eb38c5b
@jmcmichael
added loading refetch/fetchMore indicators to feed
1ed326c
@jmcmichael
added details components for each activity type
0d459ec
@jmcmichael
each activity type has its own details component
310553f
@jmcmichael
ActivityFeedItemFragment typeguards working in activity-item-detail
afbecf9
@jmcmichael
simplified activity-feed directory structure, component names
c35b68a
@jmcmichael
created detail fragments, type guards for all feed-item detail compon…
6545f0f 
…ents
@jmcmichael
moved activity detail query to feed-item-details from feed-item
546db2f
@jmcmichael
all activity detail components working w/ detail query, guards, etc.
5ff9418
@jmcmichael
activity-feed keeps track of toggled items for virt-scroll reinstanti…
435bb48 
…ation
@jmcmichael
adjusted scroller settings for smoother scrolling
5e8ee7d
@jmcmichael
Merge remote-tracking branch 'origin/main' into activity-feed-v2--mer…
cb47627 
…ge-main
@acoffman
add option to exclude civicbot events
fbb6fd0
@jmcmichael
activity-feed 'user' mode working
9e0f997
@jmcmichael
activity-feed 'subject' mode working
439fa92
@jmcmichael
activity-feed 'organization' mode working
1e5d913
@jmcmichael
includeAutomatedEvents setting/default working
acc4665
@jmcmichael jmcmichael self-assigned this Mar 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2024

You must specify one of the following labels: bugfix, housekeeping, new-feature, enhancement, ignore-for-release, dependencies in order for this PR to appear in the release notes.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2024

You must specify one of the following labels: bugfix, housekeeping, new-feature, enhancement, ignore-for-release, dependencies in order for this PR to appear in the release notes.

@jmcmichael jmcmichael added the new-feature PR Label for newly added features. Will appear in release notes. label Mar 7, 2024
@acoffman acoffman merged commit a76896a into main Oct 18, 2024
4 of 5 checks passed
@acoffman acoffman deleted the activity-feed-v2 branch October 18, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acoffman acoffman Awaiting requested review from acoffman

@susannasiebert susannasiebert Awaiting requested review from susannasiebert

Assignees

@jmcmichael jmcmichael

Labels
new-feature PR Label for newly added features. Will appear in release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmcmichael @acoffman