Merge pull request #1045 from griffithlab/dont-suppress-errors

Don't swallow errors in development mode

client/src/app/app.module.ts

@@ -21,7 +21,7 @@ import { GraphQLModule } from '@app/graphql/graphql.module'
 import { NzIconModule } from 'ng-zorro-antd/icon'
 import { CvcNetworkErrorAlertModule } from './components/app/network-error-alert/network-error-alert.module'
 import { Observable } from 'rxjs'
-import { AppLoadErrorHandler } from './core/utilities/app-reload-handler'
+import { AppErrorHandler } from './core/utilities/app-error-handler'
 import { CvcForms2Module } from '@app/forms/forms.module'
 
 registerLocaleData(en)
@@ -59,7 +59,7 @@ function initializeApiFactory(httpClient: HttpClient): () => Observable<any> {
     CookieService,
     {
       provide: ErrorHandler,
-      useClass: AppLoadErrorHandler,
+      useClass: AppErrorHandler,
     },
     { provide: NZ_I18N, useValue: en_US },
     {

client/src/app/core/utilities/app-error-handler.ts

@@ -0,0 +1,22 @@
+import { ErrorHandler, Injectable } from '@angular/core'
+import { environment } from 'environments/environment'
+
+@Injectable()
+export class AppErrorHandler implements ErrorHandler {
+  handleError(error: any): void {
+    if (environment.production) {
+      const chunkFailedMessage = /Loading chunk [\d]+ failed/
+      if (chunkFailedMessage.test(error.message)) {
+        if (
+          confirm(
+            'There is an updated version of CiVIC available. Click OK to reload.'
+          )
+        ) {
+          window.location.reload()
+        }
+      }
+    } else {
+      console.error(error)
+    }
+  }
+}