Parse input as numeric when a numeric comparison is requested #663
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the advanced search, if a user enters a non-numeric value when requesting a numeric comparison, it will generate a (still safe but) invalid SQL statement which will cause an exception. (https://griffithlab-apps.airbrake.io/projects/285901/groups/2894318614931625648/notices/2894318613519076496)
Ideally we'd do more validation client side and server side and kick back a more user friendly error in this case, but as a stopgap this will at least ensure the prepared SQL is valid and no error will occur.