Upgrade to powsybl-dependencies v2025.0.0 #46
+903
−634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
April 8, 2025 15:30
Signed-off-by: BOUTIER Charly <[email protected]>
Signed-off-by: BOUTIER Charly <[email protected]>
Signed-off-by: BOUTIER Charly <[email protected]>
Signed-off-by: BOUTIER Charly <[email protected]>
Signed-off-by: BOUTIER Charly <[email protected]>
Signed-off-by: BOUTIER Charly <[email protected]>
EstherDarkish
commented
Apr 28, 2025
| .withUntypedValue("id", generatorCreationInfos.getEquipmentId()) | ||
| .withMessageTemplate("message", e.getMessage()) | ||
| .withUntypedValue("message", e.getMessage()) |
There was a problem hiding this comment.
withMessageTemplate => withUntypedValue
This is a bugfix
added 5 commits
April 28, 2025 15:30
Signed-off-by: BOUTIER Charly <[email protected]>
Signed-off-by: BOUTIER Charly <[email protected]>
Signed-off-by: BOUTIER Charly <[email protected]>
Signed-off-by: BOUTIER Charly <[email protected]>
Signed-off-by: BOUTIER Charly <[email protected]>
EtienneLt
reviewed
May 2, 2025
| final String oldValueString = (oldValue == null || oldValue instanceof Double oldDouble && Double.isNaN(oldDouble)) | ||
| ? NO_VALUE : oldValue.toString(); | ||
| final String newValueString = (newValue == null || newValue instanceof Double newDouble && Double.isNaN(newDouble)) | ||
| ? NO_VALUE : newValue.toString(); | ||
| final String indentation = "\t".repeat(indentationLevel); |
There was a problem hiding this comment.
Yes, all indentations will be removed. This change is approved by the PO.
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: BOUTIER Charly <[email protected]>
Signed-off-by: BOUTIER Charly <[email protected]>
Signed-off-by: BOUTIER Charly <[email protected]>
Signed-off-by: BOUTIER Charly <[email protected]>
Signed-off-by: BOUTIER Charly <[email protected]>
Signed-off-by: BOUTIER Charly <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.