Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary structuredClone() call, simplify SortActions #1410

Merged
merged 1 commit into from
Jan 14, 2024

Conversation

afshinm
Copy link
Member

@afshinm afshinm commented Jan 14, 2024

No description provided.

@afshinm afshinm added bug fix Something isn't working performance labels Jan 14, 2024
Copy link

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements
81.06% (-0.05% 🔻)
1331/1642
🟡 Branches
67.3% (-0.38% 🔻)
356/529
🟢 Functions
81.9% (-0.24% 🔻)
285/348
🟢 Lines
80.66% (-0.06% 🔻)
1172/1453
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / actions.ts
8% (-0.16% 🔻)
0% 0%
8.51% (-0.19% 🔻)

Test suite run success

185 tests passing in 33 suites.

Report generated by 🧪jest coverage report action from 7090d69

Copy link

Size Change: +32 B (0%)

Total Size: 94.6 kB

Filename Size Change
dist/gridjs.js 16.4 kB +6 B (0%)
dist/gridjs.module.js 16.4 kB +6 B (0%)
dist/gridjs.production.es.min.js 16.4 kB +6 B (0%)
dist/gridjs.production.min.js 16.4 kB +7 B (0%)
dist/gridjs.umd.js 16.4 kB +7 B (0%)
ℹ️ View Unchanged
Filename Size
l10n/dist/l10n.js 3.05 kB
l10n/dist/l10n.module.js 3.13 kB
l10n/dist/l10n.umd.js 3.18 kB
plugins/selection/dist/selection.js 1.05 kB
plugins/selection/dist/selection.module.js 1.07 kB
plugins/selection/dist/selection.umd.js 1.15 kB

compressed-size-action

@afshinm afshinm merged commit 0ebdebf into master Jan 14, 2024
5 checks passed
@afshinm afshinm deleted the deepClone branch January 14, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Something isn't working performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant