Merge pull request #127 from grid-js/fix-125

fix(pipeline): unregister should check the steps datatype (#125)
grid-js · Jul 4, 2020 · efbb15f · efbb15f
2 parents 3d0b844 + f327d13
commit efbb15f
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/src/pipeline/pipeline.ts b/src/pipeline/pipeline.ts
@@ -95,11 +95,14 @@ class Pipeline<T, P = {}> extends EventEmitter<PipelineEvents<T>> {
     if (!processor) return;
 
     const subSteps = this._steps.get(processor.type);
-    this._steps.set(
-      processor.type,
-      subSteps.filter((proc) => proc != processor),
-    );
-    this.emit('updated', processor);
+
+    if (subSteps && subSteps.length) {
+      this._steps.set(
+        processor.type,
+        subSteps.filter((proc) => proc != processor),
+      );
+      this.emit('updated', processor);
+    }
   }
 
   /**

diff --git a/tests/pipeline/pipeline.test.ts b/tests/pipeline/pipeline.test.ts
@@ -70,6 +70,8 @@ describe('Pipeline', () => {
     expect(pipeline.steps).toHaveLength(1);
     pipeline.unregister(null);
     expect(pipeline.steps).toHaveLength(1);
+    pipeline.unregister(new NoopProcessor());
+    expect(pipeline.steps).toHaveLength(1);
     pipeline.unregister(proc);
     expect(pipeline.steps).toHaveLength(0);
   });