-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major set of improvements #24
Open
PetrDlouhy
wants to merge
92
commits into
greyside:master
Choose a base branch
from
PetrDlouhy:bk_devel
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…heck if it breaks something)
- introduce get_modeladmins() method for better overridability - split testing functions to decorated function and actual test run for better overriding in tests - improve tests to check for the actual Exception
run every modeladmin in separate subtest
This was referenced Aug 19, 2022
8b3300c
to
f9d972a
Compare
1ae44e3
to
6fd5af3
Compare
0f4d556
to
ebf752c
Compare
881a697
to
4778acd
Compare
488f965
to
e2ee492
Compare
fix incorrect assertions for read-only changelist views
Apply Black's suggestions
fix wrong/missing form data being used if a field uses a MultiWidget
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have started transformation of
django-admin-smoke-tests
to my new project. With it I made whole lot of improvements to it's code.The particular features are relatively well separated into separate commits, but I am not able to keep them in separate PRs without too much overhead. Especially if the essential PRs to build upon don't get merged any time soon.
@SeanHayes If you give me access to this repository, I will maintain the project here. Otherwise I will have to move to my own fork and make the changes also on PyPI
The new features are:
MPTT_ALLOW_TESTING_GENERATORS=True
when creating modelsstrict_mode
which doesn't allow failures in model creationsearch_fields
prefixes when testing specified fields*_set
attribute when testing specified fieldsAdminSiteSmokeTestMixin
by method overrides:only_modeladmins
optiononly_modeladmins
andexclude_modeladmins
(model admin name string, model admin full path string, model admin class)list_filter
There are still few things needed to finish this:
create_superuser()
get_url()
create_models()
only_modeladmins
,strict_mode
,recipes_prefix
optionsIdeally move bakery field generators to the appropriate apps: