Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major set of improvements #24

Open
wants to merge 92 commits into
base: master
Choose a base branch
from
Open

Conversation

PetrDlouhy
Copy link
Contributor

@PetrDlouhy PetrDlouhy commented Aug 19, 2022

I have started transformation of django-admin-smoke-tests to my new project. With it I made whole lot of improvements to it's code.

The particular features are relatively well separated into separate commits, but I am not able to keep them in separate PRs without too much overhead. Especially if the essential PRs to build upon don't get merged any time soon.

@SeanHayes If you give me access to this repository, I will maintain the project here. Otherwise I will have to move to my own fork and make the changes also on PyPI

The new features are:

There are still few things needed to finish this:

  • Add thorough documentation that will include:
    • override options
      • create_superuser()
      • get_url()
      • create_models()
    • only_modeladmins, strict_mode, recipes_prefix options
    • model creation and Recipes
    • manual model creation
    • using MPTT models
  • Use assertContains() at least to some element present in all general admin pages, test it in separate method to allow overridability
  • Test admin index page
  • Possibility to run subset of tests through env variables, add docs
  • Fix or document errors produced by bakery generated models and if they can be somehow fixed to minimize needed configuration of the testing
    • Field is nullable althoug save() doesn't support it
    • Field is not supported by baker
    • FileField
    • Field is too long (field lengthened in save() method)
    • Field doesn't have default
    • Model is created during related model creation
    • Field is unique

Ideally move bakery field generators to the appropriate apps:

@PetrDlouhy PetrDlouhy force-pushed the bk_devel branch 4 times, most recently from 0f4d556 to ebf752c Compare October 22, 2024 10:11
@PetrDlouhy PetrDlouhy force-pushed the bk_devel branch 2 times, most recently from 881a697 to 4778acd Compare October 22, 2024 10:32
@PetrDlouhy PetrDlouhy force-pushed the bk_devel branch 2 times, most recently from 488f965 to e2ee492 Compare October 22, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants