Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New instruments added #5

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

New instruments added #5

wants to merge 6 commits into from

Conversation

mizfit
Copy link
Collaborator

@mizfit mizfit commented Jan 1, 2016

Here are a couple instruments with functions (need to be reviewed to include error checking.)

DTM-141 Teslameter, not all functions added, just magnetic field read
out and magnetic field range selection.
All Danfysik 8000 power supply functions included with some
description, full description in manual.
@greynotgrayskies
Copy link
Owner

I'm not sure if we need a Sensor class. I thought of organizing instruments into actuators and sensors, but in the case where instruments do both, it might get confusing. Right now, it isn't very clear that the instrument can record data, but once I add an interface for that, I'll clean up here a bit.

@vassiliou
Copy link
Collaborator

I agree. Most instruments will both accept and return values. What we
choose to do with that data varies, but from the software's perspective
it's all the same.

On Tue, Jan 19, 2016 at 3:33 PM, jeffreylu017 [email protected]
wrote:

I'm not sure if we need a Sensor class. I thought of organizing
instruments into actuators and sensors, but in the case where instruments
do both, it might get confusing. Right now, it isn't very clear that the
instrument can record data, but once I add an interface for that, I'll
clean up here a bit.


Reply to this email directly or view it on GitHub
#5 (comment)
.

@mizfit
Copy link
Collaborator Author

mizfit commented Jan 20, 2016

Agreed. I wasn't quite sure in which class to place the Hall Probe (DTM
141), so I introduced the Sensor class, though perhaps in retrospect that
can be a bit confusing.

On Wed, Jan 20, 2016 at 1:33 AM, vassiliou [email protected] wrote:

I agree. Most instruments will both accept and return values. What we
choose to do with that data varies, but from the software's perspective
it's all the same.

On Tue, Jan 19, 2016 at 3:33 PM, jeffreylu017 [email protected]
wrote:

I'm not sure if we need a Sensor class. I thought of organizing
instruments into actuators and sensors, but in the case where instruments
do both, it might get confusing. Right now, it isn't very clear that the
instrument can record data, but once I add an interface for that, I'll
clean up here a bit.


Reply to this email directly or view it on GitHub
<
#5 (comment)

.


Reply to this email directly or view it on GitHub
#5 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants