chore: added purchase tokens button #148
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Utilize the meta theme-color property to make the site look better on mobile safari and other supported browsers * delete yarn-error.log add to gitignore
fix: disabling account creation button
* chore: switching to create-account library * style: code formatting Co-authored-by: Aaron Cox <[email protected]>
Deploying with
|
| Latest commit: |
e260869
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d1e0eff2.wallet-2tl.pages.dev |
| Branch Preview URL: | https://banxa-integration.wallet-2tl.pages.dev |
dafuga
force-pushed
the
banxa-integration
branch
from
8f8928d
to
05a7c5f
Compare
jnordberg
requested changes
Oct 27, 2022
| whalesplainerTokenOrder = await whalesplainerTokenOrderResponse.json() | ||
|
|
||
| console.log({whalesplainerTokenOrder}) | ||
| } catch (error) { |
There was a problem hiding this comment.
If this throws the toast below will fire as well, possibly replacing this error message with a generic one about popups.
Refactor this so that error handling only needs to happen once, preferably at the callsite and not side-effecting with a toast
|
|
||
| whalesplainerTokenOrder = await whalesplainerTokenOrderResponse.json() | ||
|
|
||
| console.log({whalesplainerTokenOrder}) |
|
|
||
| const tokenOrderUrl = `${creationServiceUrl}/api/tokens/order` | ||
|
|
||
| export const openPopupForAccount = async (accountName: Name | undefined): Promise<void> => { |
There was a problem hiding this comment.
No need for this to accept undefined, make this a burden of the caller
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.