Update migrate.ps1
to support test database used by integration tests
#5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-10863
📔 Objective
The integration tests for databases use different
secrets.json
properties than the ones used by locally running servers. This is to support not corrupting folk's local test data.Currently these test databases are not supported by
migrate.ps1
and other tooling. This PR updatesmigrate.ps1
with a--test
switch, and adds logic for connecting to and migrating these databases.The
--all
switch was modified to include running migrations against test databases as well.🧮 Side Effects
As part of this work I had to modify an old MySql migration because of an error in its manually written logic. The script in question checks for the existence of a column from system tables before trying to drop it. This doesn't check for a specific databases, and so can cause false positives if you try to have multiple databases on the same server.
📸 Screenshots
In this demo I build fresh databases from scratch and run some migrations using
migrate.ps1
. It:pwsh migrate.ps1 --all
command that skips test databases because no connection strings are found.pwsh migrate.ps1 --all
again, this time with connection strings setpwsh migrate.ps1 --test --{DATABASE}
for targeting specific test databases.migrate.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changesGreptile Summary
This PR updates the
migrate.ps1
script to support test databases used in integration tests, enhancing the flexibility of the migration process for both development and test environments.--test
switch indev/migrate.ps1
to handle test database migrations separately--all
switch to include test database migrationsdev/migrate.ps1
util/MySqlMigrations/Migrations/20231214162533_GrantIdWithIndexes.cs
to prevent issues with multiple databases on the same server